Ticket #1075 (new defect)

Opened 2 years ago

Last modified 2 months ago

0.11 compatible version

Reported by: sreimers Assigned to: athomas
Priority: normal Component: XmlRpcPlugin
Severity: normal Keywords:
Cc: martin.marcher@openforce.com, felix.schwarz@web.de, jgoering@inetsoftware.de, key@nothing.ch Trac Release: 0.11

Description

Create a 0.11 dev compatible version of this plugin. Seems some minor changes have to be made. Still trying to figure out which...

Attachments

xmlrpc-trac-0.11.patch (0.9 kB) - added by eblot on 01/16/07 21:21:56.
Basic patch for Trac-0.11 (fix up syntax issues)
xmlrpc-datetime.patch (5.7 kB) - added by eblot on 03/05/07 14:23:13.
Cumulative patch: supersedes the previous patch, add support for datetime API
xmlrpc-trac-0.11-1.patch (6.0 kB) - added by stp on 03/06/07 01:38:03.
Fix for get_changelog
xmlrpc-11.2.patch (6.3 kB) - added by ben@groovie.org on 04/25/07 06:32:52.
Cummulative patch for working xml-rpc on Trac 0.11dev-r5245
xmlrpc-11.2-genshi.diff (11.4 kB) - added by osimons on 08/17/07 09:10:12.
xmlrpc-11.2.patch converted to Genshi (no ClearSilver needed). Note the template name still ends with .cs to make the diff more correct (works fine), but should change to .html and update setup.py package_data if integrated into the repos.
xmlrpc-11.3-genshi.diff (11.4 kB) - added by mmay on 09/02/07 14:15:21.
Patch for 0.11
xmlrpc-11.3-genshi.2.diff (11.4 kB) - added by mmay on 09/02/07 14:22:03.
Patch for 0.11, Mylyn is now working :-)
Screenshot-Eclipse.png (56.9 kB) - added by r.sokoll@intershop.de on 09/03/07 10:30:02.
xmlrpcplugin-trunk.patch (1.9 kB) - added by stp on 09/08/07 22:37:18.
fixes for trunk
ticket-validate.diff (2.2 kB) - added by athomas on 09/09/07 08:44:51.
Validate permissions and ticket data before updating/creating.
trcxmlrpc-mylyn.png (33.4 kB) - added by tweitzel@synformation.com on 09/15/07 12:30:52.
Status fields (like open, closed, ...) are not shown in Mylyn dialog
ExecuteAction.patch (2.6 kB) - added by markcuk on 02/13/08 16:56:21.
Patch that allows XMLRPC to execute an action
NoneMarshalErrorChangeLog.patch (0.8 kB) - added by zefyrus@spellcaster.com.br on 09/04/08 21:14:22.
pach to allow_none marshal error
setup.py (421 bytes) - added by anonymous on 10/24/08 09:02:24.

Change History

01/05/07 20:42:42 changed by serega

01/16/07 21:21:56 changed by eblot

  • attachment xmlrpc-trac-0.11.patch added.

Basic patch for Trac-0.11 (fix up syntax issues)

(follow-up: ↓ 4 ) 01/16/07 21:27:04 changed by eblot

I've added one patch for Trac milestone:0.11.

Note that the patch is not backward compatible with milestone:0.10, as there is a case-related issue (Trac files have been renamed). This means a new directory will need to be created in the SVN repos (xmlrpcplugin/0.11)

The patch is probably not complete: I can't get the plugin to work: Trac keeps replying

HTTP error 401 (Unauthorized)

whatever the actual credentials, as well as the 'anonymous' user w/ XML_RPC permission

(follow-up: ↓ 5 ) 01/16/07 21:28:42 changed by eblot

See also ticket:4280 for the setuptools issue.

(in reply to: ↑ 2 ) 01/17/07 22:37:37 changed by eblot

Replying to eblot:

The patch is probably not complete: I can't get the plugin to work.

I'm simply stupid: this was due to an authentication mismatch issue between the XMLrpc library capabilities and the server configuration. I've added a note about authentication issue: XmlRpcPlugin#ProblemswithDigestHTTPauthentication

Anyway, the previous patch should be ok (AFAICT): XmlRpcPlugin now works fine w/ Trac 0.11

(in reply to: ↑ 3 ) 02/07/07 22:08:41 changed by anonymous

Replying to eblot:

See also ticket:4280 for the setuptools issue.

I get this exact error too. Goes away when I remove the egg

(follow-up: ↓ 9 ) 02/23/07 02:25:25 changed by stp

  • cc set to steffenp@gmx.de.

I get the following error when I try to run a query:

'from_string() takes exactly 4 arguments (3 given)' while executing 'ticket.query()'

(follow-up: ↓ 8 ) 02/23/07 02:26:49 changed by stp

And this error when I try to fetch a ticket:

'cannot marshal <type 'datetime.datetime'> objects' while executing 'ticket.get()'

(in reply to: ↑ 7 ) 03/04/07 00:52:35 changed by eblot

Replying to stp:

And this error when I try to fetch a ticket: 'cannot marshal <type 'datetime.datetime'> objects' while executing 'ticket.get()'

I've attached a new patch that should fix up this issue. I'm not sure the date computation is correct (GMT/...) but it seems ok on my environment. I've changed the API version number, as XML RPC DateTime? objects are now sent where simple integer values used to be sent for time values.

(in reply to: ↑ 6 ) 03/04/07 01:00:13 changed by eblot

Replying to stp:

I get the following error when I try to run a query: 'from_string() takes exactly 4 arguments (3 given)' while executing 'ticket.query()'

The latest patch should fix up this issue as well.

03/05/07 14:23:13 changed by eblot

  • attachment xmlrpc-datetime.patch added.

Cumulative patch: supersedes the previous patch, add support for datetime API

03/06/07 01:31:27 changed by stp

Thanks. I now get the same error for ticket.changeLog(): 'cannot marshal <type 'datetime.datetime'> objects' while executing 'ticket.changeLog()'.

03/06/07 01:38:03 changed by stp

  • attachment xmlrpc-trac-0.11-1.patch added.

Fix for get_changelog

03/06/07 01:38:04 changed by stp

Here is an updated patch. I think we should introduce a third digit for the api version that marks the 0.11 branch so both branches can be evolved independently.

04/25/07 06:32:52 changed by ben@groovie.org

  • attachment xmlrpc-11.2.patch added.

Cummulative patch for working xml-rpc on Trac 0.11dev-r5245

(follow-up: ↓ 16 ) 04/25/07 06:34:59 changed by ben@groovie.org

I have added a new cummulative patch that ensures the multicall method works given that it calls a variety of other methods which may contain datetime.datetime values that had marshal issues. Also, the from_string function apparently returned to only having 3 params so that was reverted.

With this patch, xml-rpc now works completely with Mylar+Eclipse on Trac 0.11dev-r5245.

04/26/07 19:28:45 changed by stp

I have tested the patch against the Mylar test suite without getting errors. Thanks Ben.

(follow-up: ↓ 17 ) 05/18/07 01:51:16 changed by anonymous

Hi, I have several problems with trac r5407, Mylar 2.0M3 and latest patch from ben.

Mehtod: ticket.getAvailableActions

2007-05-18 01:28:09,338 Trac[__init__] ERROR: Traceback (most recent call last):
  File "build/bdist.linux-i686/egg/tracrpc/xml_rpc.py", line 36, in process_request
  File "build/bdist.linux-i686/egg/tracrpc/api.py", line 86, in __call__
  File "build/bdist.linux-i686/egg/tracrpc/ticket.py", line 67, in getAvailableActions
  File "/usr/lib/python2.4/site-packages/Trac-0.11dev_r5407-py2.4.egg/trac/ticket/api.py", line 401, in get_available_actions
    weighted_actions = controller.get_ticket_actions(req, ticket)
  File "/usr/lib/python2.4/site-packages/Trac-0.11dev_r5407-py2.4.egg/trac/ticket/api.py", line 165, in get_ticket_actions
    status = ticket['status'] or 'new'
TypeError: unsubscriptable object

Method: ticket.status.get (only in eclipse, not in trac error.log)

'__init__() takes exactly 2 arguments (3 given)' while executing 'ticket.status.get()'

Other Error:

2007-05-18 00:23:52,596 Trac[__init__] ERROR: 'tracrpc/htdocs'
Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/Trac-0.11dev_r5407-py2.4.egg/trac/web/main.py", line 428, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/Trac-0.11dev_r5407-py2.4.egg/trac/web/main.py", line 216, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/Trac-0.11dev_r5407-py2.4.egg/trac/web/chrome.py", line 283, in process_request
    for dir in [os.path.normpath(dir[1]) for dir
  File "build/bdist.linux-i686/egg/tracrpc/web_ui.py", line 21, in get_htdocs_dirs
  File "/usr/lib/python2.4/site-packages/pkg_resources.py", line 799, in resource_filename
    return get_provider(package_or_requirement).get_resource_filename(
  File "/usr/lib/python2.4/site-packages/pkg_resources.py", line 1229, in get_resource_filename
    return self._extract_resource(manager, zip_path)
  File "/usr/lib/python2.4/site-packages/pkg_resources.py", line 1240, in _extract_resource
    zip_stat = self.zipinfo[zip_path]
KeyError: 'tracrpc/htdocs'

06/07/07 01:39:58 changed by anonymous

  • cc changed from steffenp@gmx.de to steffenp@gmx.de, martin.marcher@openforce.com.

(in reply to: ↑ 12 ) 06/07/07 02:24:08 changed by anonymous

Replying to ben@groovie.org:

With this patch, xml-rpc now works completely with Mylar+Eclipse on Trac 0.11dev-r5245.

Can confirm that for Trac 0.11dev-5245:

except the svn info below and genshi all I'm using are official debian/etch packages

$ python -V
Python 2.4.4

trac version:

$ svn info
Path: .
URL: http://svn.edgewall.org/repos/trac/trunk
Repository Root: http://svn.edgewall.org/repos/trac
Repository UUID: af82e41b-90c4-0310-8c96-b1721e28e2e2
Revision: 5617
Node Kind: directory
Schedule: normal
Last Changed Author: cboos
Last Changed Rev: 5616
Last Changed Date: 2007-06-06 15:11:50 +0200 (Wed, 06 Jun 2007)

xmlrpc version:

$ svn info
Path: .
URL: http://trac-hacks.org/svn/xmlrpcplugin/0.10
Repository Root: http://trac-hacks.org/svn
Repository UUID: 7322e99d-02ea-0310-aa39-e9a107903beb
Revision: 2283
Node Kind: directory
Schedule: normal
Last Changed Author: athomas
Last Changed Rev: 2125
Last Changed Date: 2007-03-26 01:52:19 +0200 (Mon, 26 Mar 2007)

(in reply to: ↑ 14 ) 06/07/07 03:00:35 changed by anonymous

Replying to anonymous:

Hi, I have several problems with trac r5407, Mylar 2.0M3 and latest patch from ben.

Mylar indeed doesn't work but I don't get any tracebacks. Guess it's a mylar issue actually relying on an older xmlrpc version.

  • Mylar Version 2.0.0.v20070514-1800
  • Eclipse Version 3.2.2.r322-v20070104-dCGKm0Ln38lm-8s same with 3.3RC3
2007-06-07 03:25:10,841 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:10,845 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:10,849 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:10,852 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:10,878 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:10,881 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:10,884 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:10,888 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:10,918 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:10,921 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:10,925 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:10,928 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:10,958 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:10,961 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:10,965 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:10,969 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,007 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,010 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,014 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,019 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,051 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,054 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,058 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,064 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,103 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,106 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,110 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,115 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,146 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,149 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,153 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,158 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,195 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,198 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,202 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,207 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,230 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,233 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,237 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,259 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,263 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,267 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,271 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>
2007-06-07 03:25:11,301 Trac[__init__] DEBUG: Dispatching <Request "POST /xmlrpc">
2007-06-07 03:25:11,303 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing WIKI_VIEW on <Context wiki>
2007-06-07 03:25:11,307 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing XML_RPC on <Context [root]>
2007-06-07 03:25:11,312 Trac[__init__] DEBUG: DefaultPermissionPolicy allows anonymous performing TICKET_VIEW on <Context [root]>

07/25/07 20:31:50 changed by roymartin

  • cc changed from steffenp@gmx.de, martin.marcher@openforce.com to steffenp@gmx.de, martin.marcher@openforce.com, ben@groovie.org.

To update this ticket, the latest from Steffen is that this plug-in needs to be updated with the latest development changes from the Trac repo. I have the Trac 0.11dev-r5849 and the MyLyn? Compatibility Trac Core Plug-in 2.0.0.v20070615-compatibility plug-in. I'm certainly willing to test / help to get this working for the latest release.

Thanks.

07/25/07 20:33:16 changed by roymartin

  • cc deleted.

08/17/07 09:10:12 changed by osimons

  • attachment xmlrpc-11.2-genshi.diff added.

xmlrpc-11.2.patch converted to Genshi (no ClearSilver needed). Note the template name still ends with .cs to make the diff more correct (works fine), but should change to .html and update setup.py package_data if integrated into the repos.

08/21/07 15:13:56 changed by r.sokoll@intershop.de

How do I apply xmlrpc-11.2-genshi.diff?

08/22/07 01:30:01 changed by stp

~/xmlrpcplugin/0.10$ patch -p3 < xmlrpc-11.2-genshi.diff\?format\=raw

(follow-up: ↓ 23 ) 09/01/07 14:31:23 changed by mmay

I have installed the latest patch (xmlrpc-11.2-genshi.diff) on Trac 0.11dev-r5982 and when I use Mylyn, I receive the following error:

Trac[init] DEBUG: No policy allowed <USERNAME> performing ATTACHMENT_CREATE on <Context u'[root], ticket:1, attachment' <Request "G ET u'/ticket/1'"> <trac.attachment.Attachment object at 0xb5f8d16c>>

Any hints? I know, that there seems to be a refactoring going on concerning the Attachement stuff, but is there right now a workaround?

(in reply to: ↑ 22 ; follow-up: ↓ 24 ) 09/01/07 15:07:51 changed by mmay

Sorry, this is not XMLRPC specific. After configuring Mylyn correctly, the plugin seems to work now. Thanks for the patches. Keep up the good work :-)

(in reply to: ↑ 23 ) 09/01/07 15:47:16 changed by anonymous

Replying to mmay: Okay, I can now look up tickets in Trac via the Search (using the text-search). But I cannot access a ticket via the ID. This is due to the following error:

'init() takes exactly 2 arguments (3 given)' while executing 'ticket.status.get()'.

Any hints here? https://bugs.eclipse.org/bugs/show_bug.cgi?id=175211

09/02/07 14:15:21 changed by mmay

  • attachment xmlrpc-11.3-genshi.diff added.

Patch for 0.11

09/02/07 14:22:03 changed by mmay

  • attachment xmlrpc-11.3-genshi.2.diff added.

Patch for 0.11, Mylyn is now working :-)

(follow-up: ↓ 26 ) 09/02/07 17:35:49 changed by athomas

Can others test this latest patch and confirm that it's working. If so I'll apply it to trunk.

(in reply to: ↑ 25 ) 09/02/07 20:06:17 changed by r.sokoll@intershop.de

Replying to athomas:

Can others test this latest patch and confirm that it's working. If so I'll apply it to trunk.

The status field is empty - anyway: big step forward!

(follow-up: ↓ 28 ) 09/02/07 23:28:41 changed by kev@inner-rhythm.co.uk

Well from a quick test I have just done it works for me many thanks. Been missing that since I rushed in teh 0.11 update for the new ticket workflows.

(in reply to: ↑ 27 ; follow-ups: ↓ 29 ↓ 30 ) 09/03/07 10:02:59 changed by mmay

In order to use the context of Mylyn as well (attachment to the Ticket) please also use the following patch (not really XMLRPC related, though): http://trac.edgewall.org/attachment/ticket/5945/attachment.py.patch.

The issue status is empty? Under which condition? It works fine for me though. Please write a short reply, how I can re-test this with the status and I will try to fix it.

(in reply to: ↑ 28 ; follow-up: ↓ 31 ) 09/03/07 10:29:14 changed by r.sokoll@intershop.de

Replying to mmay:

The issue status is empty? Under which condition? It works fine for me though. Please write a short reply, how I can re-test this with the status and I will try to fix it.

My trac instances aren't public, so all I can give you is the attached screenshot and these information:

  • trac 0.11dev-r5983
  • mylyn 2.0.0.0.v20070627-1400

If I call <trac-env>/xmlrpc, I see array ticket.status.getAll() exported

09/03/07 10:30:02 changed by r.sokoll@intershop.de

  • attachment Screenshot-Eclipse.png added.

(in reply to: ↑ 28 ) 09/03/07 11:24:13 changed by athomas

Replying to mmay:

In order to use the context of Mylyn as well (attachment to the Ticket) please also use the following patch (not really XMLRPC related, though): http://trac.edgewall.org/attachment/ticket/5945/attachment.py.patch.

This was fixed in trac:r5983.

(in reply to: ↑ 29 ) 09/03/07 21:50:31 changed by anonymous

Replying to r.sokoll@intershop.de: Hello, the log of eclipse shows: java.lang.NumberFormatException?: For input string: "reopened" at java.lang.NumberFormatException?.forInputString(NumberFormatException?.java:48) at java.lang.Integer.parseInt(Integer.java:447) at java.lang.Integer.parseInt(Integer.java:497) at org.eclipse.mylyn.internal.trac.core.TracXmlRpcClient?.getTicketAttributes(TracXmlRpcClient?.java:527) at org.eclipse.mylyn.internal.trac.core.TracXmlRpcClient?.updateAttributes(TracXmlRpcClient?.java:403) at org.eclipse.mylyn.internal.trac.core.AbstractTracClient?.updateAttributes(AbstractTracClient?.java:148) at org.eclipse.mylyn.internal.trac.ui.wizard.TracCustomQueryPage?$4.run(TracCustomQueryPage?.java:391) at org.eclipse.jface.operation.ModalContext?$ModalContextThread?.run(ModalContext?.java:113)

This is due to the fact, that the status is not anymore an AbstractEnum?, therefor it is handled differently then the normal Enums (e.g. Type). This means, that the id is equal to the value of the status. So, when the status value = new, the id is new as well. Perhaps I have misunderstood the concept, but this is how it seems to be implemented right now. Probably this needs to be changed in the Mylyn Trac Plugin?

(follow-up: ↓ 33 ) 09/04/07 17:39:36 changed by stp

Thanks for doing all the testing! I will update the Mylyn test server to the latest version or Trac and the XmlRpcPlugin and run the test suite. I'll report the results here within the next few days.

(in reply to: ↑ 32 ) 09/04/07 18:13:20 changed by martin.marcher@openforce.com

  • cc set to martin.marcher@openforce.com.

Replying to stp:

Thanks for doing all the testing! I will update the Mylyn test server to the latest version or Trac and the XmlRpcPlugin and run the test suite. I'll report the results here within the next few days.

Hello,

any news on this?

09/08/07 20:30:37 changed by stp

Here are the stack traces from the Trac log while running the Mylyn test suite against the latest Trac trunk and XML-RPC plugin with the xmlrpc-11.3-genshi.2.diff patch applied:

2007-09-08 14:24:09,223 Trac[web_ui] ERROR: Traceback (most recent call last)
:
  File "build/bdist.linux-i686/egg/tracrpc/web_ui.py", line 58, in process_re
quest
  File "build/bdist.linux-i686/egg/tracrpc/api.py", line 85, in __call__
  File "build/bdist.linux-i686/egg/tracrpc/ticket.py", line 45, in query
TypeError: from_string() takes exactly 3 arguments (5 given)
2007-09-08 14:24:16,033 Trac[web_ui] ERROR: Traceback (most recent call last)
:
  File "build/bdist.linux-i686/egg/tracrpc/web_ui.py", line 58, in process_re
quest
  File "build/bdist.linux-i686/egg/tracrpc/api.py", line 85, in __call__
  File "build/bdist.linux-i686/egg/tracrpc/ticket.py", line 67, in getAvailab
leActions
  File "/home/trac/share/trac-trunk/lib/python2.4/site-packages/trac/ticket/a
pi.py", line 193, in get_available_actions
    weighted_actions = controller.get_ticket_actions(req, ticket)
  File "/home/trac/share/trac-trunk/lib/python2.4/site-packages/trac/ticket/d
efault_workflow.py", line 154, in get_ticket_actions
    status = ticket['status'] or 'new'
TypeError: unsubscriptable object

09/08/07 21:04:32 changed by stp

Please disregard my previous comment, the egg build of the XML-RPC plugin contained old files. After doing a clean build all tests passed!

Please report any Mylyn specific errors for Trac 0.11 here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=175211

Alec, could you consider setting the API version to [1, 0, 0] when applying the patch? Due to the changed types (some methods return date instead of int) the API is not backwards compatible. I would like to introduce the third digit to allow evolving multiple branches (e.g. 0.10 and 0.11) separately. The first digit would indicate the branch, the second the major revision which is increased when the API changes in a non-backwards compatible way and the third digit becomes the minor version which denotes bug-fixes, API additions etc.

The only error in the Trac log was this which looks like it is to easy fix in the XML-RPC plugin:

2007-09-08 14:45:57,319 Trac[ticket] ERROR: Failure sending notification on c
hange of ticket #5: unsupported operand type(s) for -: 'int' and 'datetime.da
tetime'
Traceback (most recent call last):
  File "build/bdist.linux-i686/egg/tracrpc/ticket.py", line 109, in update
  File "/home/trac/share/trac-trunk/lib/python2.4/site-packages/trac/ticket/n
otification.py", line 81, in notify
    for change in TicketModule(self.env).grouped_changelog_entries(
  File "/home/trac/share/trac-trunk/lib/python2.4/site-packages/trac/ticket/w
eb_ui.py", line 1156, in grouped_changelog_entries
    changelog = ticket.get_changelog(when=when, db=db)
  File "/home/trac/share/trac-trunk/lib/python2.4/site-packages/trac/ticket/m
odel.py", line 284, in get_changelog
    when_ts = when and to_timestamp(when) or 0
  File "/home/trac/share/trac-trunk/lib/python2.4/site-packages/trac/util/dat
efmt.py", line 55, in to_timestamp
    diff = dt - _epoc
TypeError: unsupported operand type(s) for -: 'int' and 'datetime.datetime'

09/08/07 21:52:42 changed by r.sokoll@intershop.de

I'm a little bit confused: In the plugin source, we have

Which one should I use? If trunk, is then xmlrpc-11.3-genshi.2.diff still needed?

09/08/07 22:37:18 changed by stp

  • attachment xmlrpcplugin-trunk.patch added.

fixes for trunk

(follow-up: ↓ 38 ) 09/08/07 22:37:19 changed by stp

I ran the tests against 0.10 + patch not realizing that the patch had already been applied to trunk.

I just ran the tests again using trunk this time. Please see the attached patch which fixes an error when the comment of a wiki change is null and implements the version numbering scheme I proposed in my previous comment.

Alec, are there any plans to support updating of tickets for users without TICKET_ADMIN priviliges (http://trac-hacks.org/changeset/2614)? I am afraid requiring these privileges will make it difficult for many users to edit tickets through XML-RPC particularly in public repositories since they won't grant more than TICKET_MODIFY privileges.

(in reply to: ↑ 37 ) 09/08/07 22:47:41 changed by anonymous

Replying to stp:

I ran the tests against 0.10 + patch not realizing that the patch had already been applied to trunk.

Ahh, that is why I don't see any differences between 0.10 and trunk. Unfortunately, the status field is still empty - what makes the plugin quite unusable (nearly nobody is interested in closed tickets)

(follow-up: ↓ 40 ) 09/08/07 22:57:15 changed by stp

Replying to anonymous: Unfortunately, the status field is still empty - what makes the plugin quite unusable (nearly nobody is interested in closed tickets)

This sounds like a Mylyn specific problem (unless there are error stack traces in your Trac log) that should be reported here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=175211 .

(in reply to: ↑ 39 ) 09/08/07 23:05:59 changed by r.sokoll@intershop.de

Replying to stp:

Replying to anonymous: Unfortunately, the status field is still empty - what makes the plugin quite unusable (nearly nobody is interested in closed tickets)

This sounds like a Mylyn specific problem (unless there are error stack traces in your Trac log)

No, I don't have any stack traces in trac's log. BUT: The same Mylyn works perfectly together with a 0.10.3. If I only could provide any useful information, I would be glad to do so.

09/09/07 00:18:52 changed by stp

The errors you describe are caused by changes in the ticket workflow system that were made in Trac 0.11. I have committed a fix for Mylyn (which requires the XML-RPC plugin trunk + the last patch I posted here).

As I said before it is important to report errors like that in the right place otherwise reports may go unnoticed (e.g. Mylyn screen shots are only helpful in the Mylyn bug tracker). Don't worry too much about providing many details initially. You will be asked if additional information is required and it is more important to be responsive then :).

09/09/07 08:14:58 changed by athomas

(In [2624]) Applied a patch (refs #1075) from stp which fixes some more 0.11 problems. Thanks!

09/09/07 08:44:51 changed by athomas

  • attachment ticket-validate.diff added.

Validate permissions and ticket data before updating/creating.

09/09/07 08:46:15 changed by athomas

Replying to stp:

Alec, are there any plans to support updating of tickets for users without TICKET_ADMIN priviliges (http://trac-hacks.org/changeset/2614)? I am afraid requiring these privileges will make it difficult for many users to edit tickets through XML-RPC particularly in public repositories since they won't grant more than TICKET_MODIFY privileges.

Agreed. It was a stop-gap measure at best.

Try this patch and let me know how it goes. It seems okay to me, but more testing would be helpful.

09/12/07 11:29:18 changed by felixschwarz

  • cc changed from martin.marcher@openforce.com to martin.marcher@openforce.com, felix.schwarz@web.de.
  • owner changed from athomas to felixschwarz.
  • status changed from new to assigned.

09/12/07 11:30:55 changed by felixschwarz

  • owner changed from felixschwarz to athomas.
  • status changed from assigned to new.

Sorry for spamming. The owner change happened automatically and I do not want to own this bug.

09/15/07 12:30:52 changed by tweitzel@synformation.com

  • attachment trcxmlrpc-mylyn.png added.

Status fields (like open, closed, ...) are not shown in Mylyn dialog

(follow-up: ↓ 47 ) 09/15/07 12:37:01 changed by tweitzel@synformation.com

Trac XML-RPC r2638 and Trac r6011 (but was also present in earlier revisions): status field in Mylyn dialog (Mylyn Trac Connector 2.0.0) is not filled.

I'm really not sure if this is a Mylyn problem or a Trac XML-RPC plugin problem, but I start here ;-).

(in reply to: ↑ 46 ) 09/15/07 12:42:17 changed by r.sokoll@intershop.de

Replying to tweitzel@synformation.com:

Trac XML-RPC r2638 and Trac r6011 (but was also present in earlier revisions): status field in Mylyn dialog (Mylyn Trac Connector 2.0.0) is not filled. I'm really not sure if this is a Mylyn problem or a Trac XML-RPC plugin problem, but I start here ;-).

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=175211#c13 ff.

12/19/07 20:15:06 changed by martin@marcher.name

Hello,

just installed r2917 from trunk and it "just works" with trac0.11.

our trac is: r5617

if anyones interested. I tested with mylyn with

  • eclipse 3.2 where the attributes didn't update properly. But basic work was possible
  • eclipse 3.3 - all worked

hth martin

02/13/08 16:56:21 changed by markcuk

  • attachment ExecuteAction.patch added.

Patch that allows XMLRPC to execute an action

(follow-up: ↓ 50 ) 02/13/08 16:56:58 changed by markcuk

Not sure if I just missed this functionality somewhere, but I didn't find anything that lets you execute an action so I'm adding a patch for it.

(in reply to: ↑ 49 ) 03/16/08 13:41:18 changed by anonymous

Replying to markcuk:

Not sure if I just missed this functionality somewhere, but I didn't find anything that lets you execute an action so I'm adding a patch for it.

add_warning() is not useful in an XML-RPC call. Rather, you should accumulate the warnings into a single message and raise an xmlrpclib.Fault.

07/14/08 13:39:38 changed by Henry78

  • cc changed from martin.marcher@openforce.com, felix.schwarz@web.de to martin.marcher@openforce.com, felix.schwarz@web.de, henry78@gmx.at.

(follow-up: ↓ 53 ) 07/15/08 09:11:21 changed by Henry78

  • cc changed from martin.marcher@openforce.com, felix.schwarz@web.de, henry78@gmx.at to martin.marcher@openforce.com, felix.schwarz@web.de.

Works for me. Didn't use the trunk version, and when i compiled trunk the old module (which i installed via easy_install) still sat in the pyhton/site-packages. I removed everything and installed from trunk, works like a charm.

(in reply to: ↑ 52 ) 07/23/08 12:43:19 changed by CN

Works too for me with Trac 0.11, eclipse 3.3.2, Mylyn Trac Connector 2.3.0v20080225 and XMLRPC from trunk.

08/18/08 16:31:15 changed by anonymous

  • cc changed from martin.marcher@openforce.com, felix.schwarz@web.de to martin.marcher@openforce.com, felix.schwarz@web.de, jgoering@inetsoftware.de.

Works for the most part for me but when fetching queries with more than 100 tickets, Mylyn shows me the error dialog box:

'cannot marshal None unless allow_none is enabled' while executing 'system.multicall()'

It seems Mylyn is trying a multicall to fetch batches of 100 tickets at a time or something, and XMLRPC doesn't like it?

Any thoughts on how to fix this problem?

08/22/08 11:52:26 changed by jgoering@inetsoftware.de

More info on this: it's not the fetching of so many tickets but rather that one of my custom fields had the value not set.

09/04/08 21:14:22 changed by zefyrus@spellcaster.com.br

  • attachment NoneMarshalErrorChangeLog.patch added.

pach to allow_none marshal error

09/04/08 21:14:57 changed by zefyrus@spellcaster.com.br

Hi,

The ticket.changeLog() has no check for possible errors like: deleted user(author) or field so an None is submitted to xmlrpclib.dumps ant it raises the exception. The Trac backend for Mylyn 3.3/3.4 doesn't understand None either so those variables must return some string.

patch attached attachment:NoneMarshalErrorChangeLog.patch

10/21/08 10:40:57 changed by anonymous

  • cc changed from martin.marcher@openforce.com, felix.schwarz@web.de, jgoering@inetsoftware.de to martin.marcher@openforce.com, felix.schwarz@web.de, jgoering@inetsoftware.de, key@nothing.ch.

10/24/08 09:02:24 changed by anonymous

  • attachment setup.py added.

01/08/09 13:18:09 changed by anonymous

Just wondering if there is going to be a formal release of the plugin for trac 0.11.

Thanks


Add/Change #1075 (0.11 compatible version)




Change Properties
Action